Skip to content

Chore: GCP Postgres integration tests#5143

Merged
vchan merged 2 commits intomainfrom
vchan/gcp-postgres-integration-tests
Aug 13, 2025
Merged

Chore: GCP Postgres integration tests#5143
vchan merged 2 commits intomainfrom
vchan/gcp-postgres-integration-tests

Conversation

@vchan
Copy link
Contributor

@vchan vchan commented Aug 12, 2025

No description provided.

@vchan vchan force-pushed the vchan/gcp-postgres-integration-tests branch 7 times, most recently from f60f1db to eb4ba6f Compare August 12, 2025 23:44
@vchan vchan marked this pull request as ready for review August 12, 2025 23:44
@vchan vchan requested review from a team and Copilot August 12, 2025 23:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds integration test support for GCP Postgres by configuring the necessary test infrastructure and updating connection validation logic.

  • Adds GCP Postgres as a new integration test engine
  • Updates test configuration to handle the gcp_postgres engine type
  • Removes conflicting password/IAM authentication validation to allow both authentication methods

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/core/engine_adapter/integration/init.py Registers GCP Postgres as a cloud-based integration test engine
tests/core/engine_adapter/integration/test_integration.py Adds logic to properly handle the gcp_postgres engine type during test initialization
tests/core/engine_adapter/integration/config.yaml Defines GCP Postgres connection configuration with environment variables
sqlmesh/core/config/connection.py Removes validation that prevented using both password and IAM authentication
Makefile Adds gcp-postgres-test target with required environment variable guards
.circleci/manage-test-db.sh Implements GCP Postgres database management functions using Cloud SQL Proxy
.circleci/continue_config.yml Integrates GCP Postgres into CI workflow and sets database environment variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vchan vchan enabled auto-merge (squash) August 13, 2025 00:03
@vchan vchan force-pushed the vchan/gcp-postgres-integration-tests branch from d62e6bb to e0b6d55 Compare August 13, 2025 00:26
@vchan vchan merged commit eed4c26 into main Aug 13, 2025
25 of 28 checks passed
@vchan vchan deleted the vchan/gcp-postgres-integration-tests branch August 13, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants