Merged
Conversation
f60f1db to
eb4ba6f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration test support for GCP Postgres by configuring the necessary test infrastructure and updating connection validation logic.
- Adds GCP Postgres as a new integration test engine
- Updates test configuration to handle the
gcp_postgresengine type - Removes conflicting password/IAM authentication validation to allow both authentication methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/engine_adapter/integration/init.py | Registers GCP Postgres as a cloud-based integration test engine |
| tests/core/engine_adapter/integration/test_integration.py | Adds logic to properly handle the gcp_postgres engine type during test initialization |
| tests/core/engine_adapter/integration/config.yaml | Defines GCP Postgres connection configuration with environment variables |
| sqlmesh/core/config/connection.py | Removes validation that prevented using both password and IAM authentication |
| Makefile | Adds gcp-postgres-test target with required environment variable guards |
| .circleci/manage-test-db.sh | Implements GCP Postgres database management functions using Cloud SQL Proxy |
| .circleci/continue_config.yml | Integrates GCP Postgres into CI workflow and sets database environment variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
erindru
approved these changes
Aug 12, 2025
d62e6bb to
e0b6d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.