Skip to content

chore(vscode): fix test stability #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Aug 13, 2025
Merged

chore(vscode): fix test stability #5145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions vscode/extension/tests/quickfix.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,22 @@ test('noselectstar quickfix', async ({ page, sharedCodeServer, tempDir }) => {
await openProblemsView(page)

await page.getByRole('button', { name: 'Show fixes' }).click()
await page
.getByRole('menuitem', { name: 'Replace SELECT * with' })
.first()
.click()
// Wait for the quick fix menu to appear and click the specific action within it.
const quickFixMenu = page.getByRole('menu')
await quickFixMenu.waitFor({ state: 'visible' })
const replaceSelectStar = quickFixMenu.getByRole('menuitem', {
name: /Replace SELECT \* with/i,
})
await replaceSelectStar.first().waitFor({ state: 'visible' })
await replaceSelectStar.first().click()

// Wait for the quick fix to be applied
await page.waitForTimeout(2_000)
// Wait for the quick fix to be applied by polling the file content
await expect
.poll(async () => {
const content = (await fs.readFile(modelPath)).toString('utf8')
return content.includes('SELECT *')
})
.toBeFalsy()

// Assert that the model no longer contains SELECT * but SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date
const readUpdatedFile = (await fs.readFile(modelPath)).toString('utf8')
Expand Down