Chore!: deprecate support for mixing Jinja & SQLMesh macros#5158
Closed
georgesittas wants to merge 1 commit intomainfrom
Closed
Chore!: deprecate support for mixing Jinja & SQLMesh macros#5158georgesittas wants to merge 1 commit intomainfrom
georgesittas wants to merge 1 commit intomainfrom
Conversation
3c24421 to
51c51c1
Compare
Contributor
Author
|
Discussed more and for now we'll avoid doing this after all, as there's a risk of breaking projects that rely on builtin datetime sqlmesh macro variables. For future reference, an example like this doesn't work today, because we don't have an AST at load time to extract the referenced variables and populate the However, if instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixing jinja and sqlmesh macros is discouraged today and it probably doesn't quite work in many cases. This PR deprecates any support that existed for mixing the two systems, in favour of reducing the overhead involved in rendering jinja-based queries (e.g., that come from dbt projects). Now, sqlmesh macros are only rendered for non-jinja-based models.