Skip to content

Fix: Remove leftover forward-only category usage when categorizing orphaned snapshots #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 1 commit into from
Aug 19, 2025
Merged

Fix: Remove leftover forward-only category usage when categorizing orphaned snapshots #5190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions sqlmesh/core/plan/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,17 +733,11 @@ def _get_orphaned_indirect_change_category(
# One of the new parents in the chain was breaking so this indirect snapshot is breaking
return SnapshotChangeCategory.INDIRECT_BREAKING

if SnapshotChangeCategory.FORWARD_ONLY in previous_parent_categories:
# One of the new parents in the chain was forward-only so this indirect snapshot is forward-only
indirect_category = SnapshotChangeCategory.FORWARD_ONLY
elif (
previous_parent_categories.intersection(
{
SnapshotChangeCategory.NON_BREAKING,
SnapshotChangeCategory.INDIRECT_NON_BREAKING,
}
)
and indirect_category != SnapshotChangeCategory.FORWARD_ONLY
if previous_parent_categories.intersection(
{
SnapshotChangeCategory.NON_BREAKING,
SnapshotChangeCategory.INDIRECT_NON_BREAKING,
}
):
# All changes in the chain were non-breaking so this indirect snapshot can be non-breaking too
indirect_category = SnapshotChangeCategory.INDIRECT_NON_BREAKING
Expand Down