feat: mimic dbt nuanced on_schema_change behavior#5203
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/schema_differ_dbt
branch
3 times, most recently
from
7915a2f to
895af54
Compare
erindru
approved these changes
Aug 22, 2025
| SCHEMA_DIFFER = SchemaDiffer( | ||
| compatible_types={ | ||
| SCHEMA_DIFFER_KWARGS = { | ||
| "compatible_types": { |
Collaborator
There was a problem hiding this comment.
nit (and I guess this is also a matter of opinion): did you consider using the dict() constructor so you can keep treating the kwarg names as identifiers instead of strings?
Collaborator
Author
There was a problem hiding this comment.
I don't have a preference either way. Just leaving how it is to save some time.
eakmanrq
force-pushed
the
eakmanrq/schema_differ_dbt
branch
from
674d9e5 to
1134354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the gaps outlined in this PR: #5193
Key changes:
All of these changes are to support dbt adapter - there is not a good use case for them for native users.
The biggest gap remaining to support dbt
on_schema_changeis robust integration tests comparing dbt to dbt adapter to ensure they behave the same. Since this is runtime related, and we have loading errors to address, will prioritize this later as needed.