Conversation
2ccb20f to
52029b6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tests the functionality of documentation blocks in dbt models by adding test cases for both inline descriptions and doc block references. The changes validate that both forms of documentation are properly parsed and accessible in the SQLMesh dbt integration.
- Adds test fixtures for documentation block functionality
- Creates unit tests to verify inline descriptions and doc block references work correctly
- Includes a standalone testing script to validate the implementation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/dbt/sushi_test/models/waiters_doc_block.md | Adds a dbt docs block definition for waiters model |
| tests/fixtures/dbt/sushi_test/models/schema.yml | Updates schema with inline description for top_waiters and doc block reference for waiters |
| tests/dbt/test_docs.py | Creates unit tests to verify both inline descriptions and doc block references are properly parsed |
| test_descriptions.py | Adds debugging script to inspect how descriptions are loaded and accessed |
| examples/sushi_dbt/models/waiters_doc_block.md | Duplicate docs block file in examples directory |
| examples/sushi_dbt/models/waiter_as_customer_by_day.sql | Removes entire SQL model definition |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
84332cb to
27ee8bb
Compare
izeigerman
approved these changes
Aug 25, 2025
- tests dbt docs blocks
27ee8bb to
b516083
Compare
Co-authored-by: Themis Valtinos <73662635+themisvaltinos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.