Skip to content

chore: testing docs additions#5221

Merged
benfdking merged 3 commits intomainfrom
dbt_docs_blocks
Aug 26, 2025
Merged

chore: testing docs additions#5221
benfdking merged 3 commits intomainfrom
dbt_docs_blocks

Conversation

@benfdking
Copy link
Contributor

@benfdking benfdking commented Aug 25, 2025

  • tests docs blocks work

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tests the functionality of documentation blocks in dbt models by adding test cases for both inline descriptions and doc block references. The changes validate that both forms of documentation are properly parsed and accessible in the SQLMesh dbt integration.

  • Adds test fixtures for documentation block functionality
  • Creates unit tests to verify inline descriptions and doc block references work correctly
  • Includes a standalone testing script to validate the implementation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/fixtures/dbt/sushi_test/models/waiters_doc_block.md Adds a dbt docs block definition for waiters model
tests/fixtures/dbt/sushi_test/models/schema.yml Updates schema with inline description for top_waiters and doc block reference for waiters
tests/dbt/test_docs.py Creates unit tests to verify both inline descriptions and doc block references are properly parsed
test_descriptions.py Adds debugging script to inspect how descriptions are loaded and accessed
examples/sushi_dbt/models/waiters_doc_block.md Duplicate docs block file in examples directory
examples/sushi_dbt/models/waiter_as_customer_by_day.sql Removes entire SQL model definition
Comments suppressed due to low confidence (2)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@benfdking benfdking force-pushed the dbt_docs_blocks branch 5 times, most recently from 84332cb to 27ee8bb Compare August 25, 2025 19:23
@benfdking benfdking enabled auto-merge (squash) August 25, 2025 19:32
- tests dbt docs blocks
benfdking and others added 2 commits August 26, 2025 13:45
Co-authored-by: Themis Valtinos <73662635+themisvaltinos@users.noreply.github.com>
@benfdking benfdking enabled auto-merge (squash) August 26, 2025 12:28
@benfdking benfdking merged commit a026f13 into main Aug 26, 2025
36 of 37 checks passed
@benfdking benfdking deleted the dbt_docs_blocks branch August 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants