Fix: handle whitespace trimming in dbt test-to-macro jinja normalization#5232
Merged
georgesittas merged 1 commit intomainfrom Aug 27, 2025
Merged
Conversation
georgesittas
force-pushed
the
jo/improve_dbt_generic_test_to_macro_conversion
branch
from
67ef666 to
10ad6e0
Compare
georgesittas
changed the title
georgesittas
force-pushed
the
jo/improve_dbt_generic_test_to_macro_conversion
branch
from
10ad6e0 to
5c43859
Compare
georgesittas
changed the title
erindru
approved these changes
Aug 27, 2025
georgesittas
deleted the
jo/improve_dbt_generic_test_to_macro_conversion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't handle whitespace trimming in the
{% test foo %} -> {% macro test_foo %}conversion today, which results in this error:Encountered unknown tag 'test'. This PR address this. An example of such a test in the wild can be found here.