Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/jinja_find_variable_node_if_nested
branch
from
fea7a54 to
67465f2
Compare
eakmanrq
force-pushed
the
eakmanrq/jinja_find_variable_node_if_nested
branch
from
67465f2 to
cd11ba5
Compare
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Just a couple of comments but LGTM otherwise.
georgesittas
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See test for example where the variable is nested and we need to find the actual variable reference.