Fix(dbt_cli): Add global error handling group for dbt subcommands#5239
Merged
themisvaltinos merged 5 commits intomainfrom Aug 27, 2025
Merged
Fix(dbt_cli): Add global error handling group for dbt subcommands#5239themisvaltinos merged 5 commits intomainfrom
themisvaltinos merged 5 commits intomainfrom
Conversation
erindru
approved these changes
Aug 27, 2025
Collaborator
erindru
left a comment
erindru
left a comment
There was a problem hiding this comment.
This is better, i'll adjust my other PR
erindru
reviewed
Aug 27, 2025
tests/dbt/cli/test_global_flags.py
Outdated
|
|
||
|
|
||
| def test_run_error_handler(jaffle_shop_duckdb: Path, invoke_cli: t.Callable[..., Result]): | ||
| with patch("sqlmesh_dbt.operations.DbtOperations.run") as mock_run: |
Collaborator
There was a problem hiding this comment.
oh, actually, shouldnt this use pytest's MockerFixture?
Contributor
Author
There was a problem hiding this comment.
right revised to use mockerfixture instead
Collaborator
There was a problem hiding this comment.
thanks. arguably it's less pretty but MockerFixture plays nicely with pytest and helps prevent mocks from clobbering each other between tests
themisvaltinos
force-pushed
the
themis/dbttrace
branch
from
4d76497 to
e704ca0
Compare
themisvaltinos
force-pushed
the
themis/dbttrace
branch
from
e704ca0 to
1585fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the traceback is printed for the sqlmesh_dbt subcommands, this introduces a custom click group subclass that automatically wraps all subcommand callbacks with
cli_global_error_handlerensuring error handling across the cli commands likerun,listand in case more are added in the future.