Chore: Add integration test to verify before all execution order#5241
Merged
themisvaltinos merged 1 commit intomainfrom Aug 27, 2025
Merged
Chore: Add integration test to verify before all execution order#5241themisvaltinos merged 1 commit intomainfrom
themisvaltinos merged 1 commit intomainfrom
Conversation
erindru
approved these changes
Aug 27, 2025
georgesittas
approved these changes
Aug 27, 2025
Comment on lines
+6466
to
+6475
| state_tables = [ | ||
| "_snapshots", | ||
| "_environments", | ||
| "_versions", | ||
| "_intervals", | ||
| "_auto_restatements", | ||
| "_environment_statements", | ||
| "_plan_dags", | ||
| ] | ||
|
|
Contributor
There was a problem hiding this comment.
Why do we need to ignore those? So that the before all shows up as the first statement?
Collaborator
There was a problem hiding this comment.
I would assume so, rather than trying to identify it as the 86th statement after all the migration queries have run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to verify before all and after all order of execution