Skip to content

chore: create make command install dbt version #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Aug 28, 2025
Merged

chore: create make command install dbt version #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dbt-version:
[
'1.3.0',
'1.4.0',
'1.5.0',
'1.6.0',
'1.7.0',
'1.8.0',
'1.9.0',
'1.10.0',
]
dbt-version: ['1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '1.9', '1.10']
steps:
- uses: actions/checkout@v5
- name: Set up Python
Expand All @@ -96,18 +86,7 @@ jobs:
run: |
uv venv .venv
source .venv/bin/activate
sed -i 's/"pydantic>=2.0.0"/"pydantic"/g' pyproject.toml
if [[ "${{ matrix.dbt-version }}" == "1.10.0" ]]; then
# For 1.10.0: only add version to dbt-core, remove versions from all adapter packages
sed -i -E 's/"(dbt-core)[^"]*"/"\1~=${{ matrix.dbt-version }}"/g' pyproject.toml
# Remove version constraints from all dbt adapter packages
sed -i -E 's/"(dbt-(bigquery|duckdb|snowflake|athena-community|clickhouse|databricks|redshift|trino))[^"]*"/"\1"/g' pyproject.toml
else
# For other versions: apply version to all dbt packages
sed -i -E 's/"(dbt-[^">=<~!]+)[^"]*"/"\1~=${{ matrix.dbt-version }}"/g' pyproject.toml
fi
UV=1 make install-dev
uv pip install pydantic>=2.0.0 --reinstall
UV=1 make install-dev-dbt-${{ matrix.dbt-version }}
- name: Run dbt tests
# We can't run slow tests across all engines due to tests requiring DuckDB and old versions
# of DuckDB require a version of DuckDB we no longer support
Expand Down
34 changes: 34 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ else
PIP := pip3
endif

UNAME_S := $(shell uname -s)
ifeq ($(UNAME_S),Darwin)
SED_INPLACE = sed -i ''
else
SED_INPLACE = sed -i
endif

install-dev:
$(PIP) install -e ".[dev,web,slack,dlt,lsp]" ./examples/custom_materializations

Expand All @@ -15,6 +22,33 @@ install-doc:
install-pre-commit:
pre-commit install

install-dev-dbt-%:
@version="$*"; \
period_count=$$(echo "$$version" | tr -cd '.' | wc -c); \
if [ "$$period_count" -eq 0 ]; then \
version="$${version:0:1}.$${version:1}"; \
elif [ "$$period_count" -eq 1 ]; then \
version="$$version.0"; \
fi; \
echo "Installing dbt version: $$version"; \
cp pyproject.toml pyproject.toml.backup; \
$(SED_INPLACE) 's/"pydantic>=2.0.0"/"pydantic"/g' pyproject.toml; \
if [ "$$version" = "1.10.0" ]; then \
echo "Applying special handling for dbt 1.10.0"; \
$(SED_INPLACE) -E 's/"(dbt-core)[^"]*"/"\1~='"$$version"'"/g' pyproject.toml; \
$(SED_INPLACE) -E 's/"(dbt-(bigquery|duckdb|snowflake|athena-community|clickhouse|databricks|redshift|trino))[^"]*"/"\1"/g' pyproject.toml; \
else \
echo "Applying version $$version to all dbt packages"; \
$(SED_INPLACE) -E 's/"(dbt-[^"><=~!]+)[^"]*"/"\1~='"$$version"'"/g' pyproject.toml; \
fi; \
$(MAKE) install-dev; \
if [ "$$version" = "1.6.0" ]; then \
echo "Applying pydantic override for dbt 1.6.0"; \
$(PIP) install 'pydantic>=2.0.0' --reinstall; \
fi; \
mv pyproject.toml.backup pyproject.toml; \
echo "Restored original pyproject.toml"

style:
pre-commit run --all-files

Expand Down