fix: pydantic v1 issues with dbt 1.6 semantic models#5255
Merged
Conversation
georgesittas
approved these changes
Aug 28, 2025
eakmanrq
force-pushed
the
eakmanrq/dbt_16_pydantic_v1_semantic
branch
6 times, most recently
from
56b4a90 to
a0e1dea
Compare
eakmanrq
force-pushed
the
eakmanrq/dbt_16_pydantic_v1_semantic
branch
from
a0e1dea to
48a7384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt 1.6 requires Pydantic v1 but this is just to support semantic models. Prior to this change, if a user is on 1.6 and has a semantic model they will get a Pydantic error trying to validate their semantic models since it expects v1 but we forced v2.
This PR disables Semantic Models for 1.6+. It does this by disabling the validation that happens on manifest load and then removes any loaded semantic models from the manifest. This ensures we don't interact with these objects going forward.
This PR could be adjusted to just remove semantic models for 1.6 and leave them for 1.7+ but I don't see why the SQLMesh adapter would care about semantic models so it seems better to remove them entirely.