Chore: Address more integration test flakiness#5258
Merged
Conversation
erindru
commented
Aug 28, 2025
| # because unregister() apparently doesnt unregister plugins cleanly in such a way they can be re-registered | ||
| # | ||
| # so what we end up doing below is a small monkey-patch to adjust the call order of the hooks | ||
| pm = config.pluginmanager |
Collaborator
Author
There was a problem hiding this comment.
I tried quite a few things, including trying to register tests as a pytest plugin in pyproject.toml (which has its own set of problems) before arriving at this implementation as the least horrendous option
eakmanrq
reviewed
Aug 28, 2025
.circleci/continue_config.yml
Outdated
Comment on lines
+313
to
+316
| #filters: | ||
| # branches: | ||
| # only: | ||
| # - main |
eakmanrq
approved these changes
Aug 28, 2025
This reverts commit f455332.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses:
teardown failed on attempt N! Exiting immediately!when there is aStashKeyerrorI had a handler for capturing the
StashKeyerrors and it worked - ifpytest-retrywasnt in the mix. So it was working forstyle_and_cicd_testsbut not the engine adapter integration tests.pytest-retryregisters its own handler, which runs before ours and bombs out before we even have a chance to handle the error.So this PR adjusts the hook call order at runtime to call ours first before the one from
pytest-retry