Fix: Match dbt handling of cluster_by config for view materializations#5266
Merged
Fix: Match dbt handling of cluster_by config for view materializations#5266
Conversation
sqlmesh/dbt/model.py
Outdated
Comment on lines
+470
to
+471
| if self.cluster_by: | ||
| if self.cluster_by and not isinstance(kind, ViewKind): |
Contributor
There was a problem hiding this comment.
Don't we want to push this further down into sqlmesh's model validator? I thought it wasn't possible to cluster normal views in general.
Contributor
Author
There was a problem hiding this comment.
It can be pushed down into sqlmesh; however, will it match how sqlmesh wants to handle misconfiguration? I'm under the impression that sqlmesh wants to error, not ignore. wdyt?
Contributor
There was a problem hiding this comment.
I see, that makes sense to me. Do we already throw an error today for this? (Just curious, fine if we don't for now.)
georgesittas
approved these changes
Sep 3, 2025
Contributor
|
Let's add a test for this. |
crericha
force-pushed
the
ignore-view-cluster-by
branch
from
64f6cba to
bb7f3d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt disregards cluster_by config when creating tables for view models.