Merged
Conversation
eakmanrq
commented
Sep 1, 2025
Comment on lines
-259
to
-264
| for field in ("forward_only", "auto_restatement_cron"): | ||
| field_val = getattr(self, field, None) | ||
| if field_val is None: | ||
| field_val = self.meta.get(field, None) | ||
| if field_val is not None: | ||
| incremental_kind_kwargs[field] = field_val |
Collaborator
Author
There was a problem hiding this comment.
This used to add forward_only to the incremental_kind_kwargs when it should really be part of incremental_by_kind_kwargs. This PR fixes that.
eakmanrq
commented
Sep 1, 2025
| disable_restatement = ( | ||
| not self.full_refresh if self.full_refresh is not None else False | ||
| ) | ||
| incremental_by_kind_kwargs["disable_restatement"] = disable_restatement |
Collaborator
Author
There was a problem hiding this comment.
disable_restatement is part of IncrementBy so it should be part of incremental_by_kind_kwargs and this PR adds it to it.
eakmanrq
commented
Sep 1, 2025
| merge_filter = None | ||
| if self.incremental_predicates: | ||
| dialect = self.dialect(context) | ||
| incremental_kind_kwargs["merge_filter"] = exp.and_( |
Collaborator
Author
There was a problem hiding this comment.
merge_filter is not part of the incremental kind model so this PR fixes that.
erindru
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not add runtime support for microbatch - it just allows the dbt adapter to load microbatch models. Follow up PR(s) will be adding runtime support so it matches dbt behavior.