Fix: Ignore bigquery partition_by config when the target isn't bigquery#5280
Merged
Fix: Ignore bigquery partition_by config when the target isn't bigquery#5280
Conversation
Collaborator
|
Can you add a test to validate this behaviour? |
crericha
force-pushed
the
ignore-bq-partition-by
branch
from
0051794 to
4c07ad3
Compare
Contributor
Author
Done |
crericha
force-pushed
the
ignore-bq-partition-by
branch
from
4c07ad3 to
c478480
Compare
izeigerman
reviewed
Sep 3, 2025
izeigerman
reviewed
Sep 3, 2025
| else: | ||
| partitioned_by.append(self._big_query_partition_by_expr(context)) | ||
| optional_kwargs["partitioned_by"] = partitioned_by | ||
| elif isinstance(self.partition_by, dict): |
Collaborator
There was a problem hiding this comment.
what if neither dict nor list?
Contributor
Author
There was a problem hiding this comment.
The validator ensures its one or the other.
https://github.com/TobikoData/sqlmesh/blob/d3079815cff6c73fe99f76c719967e83394d4258/sqlmesh/dbt/model.py#L168
izeigerman
reviewed
Sep 3, 2025
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
crericha
force-pushed
the
ignore-bq-partition-by
branch
from
75c37f3 to
6910716
Compare
izeigerman
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt ignores bigquery partition_by config when not using the bigquery plugin. Have sqlmesh mimic this behavior.