Chore: improve test stability and address some warnings#5293
Merged
Conversation
erindru
force-pushed
the
erin/improve-tests
branch
from
d3a68fb to
113825b
Compare
erindru
commented
Sep 4, 2025
.circleci/continue_config.yml
Outdated
| branches: | ||
| only: | ||
| - main | ||
| #filters: |
georgesittas
approved these changes
Sep 4, 2025
This reverts commit a7dac01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After spending an ungodly amount of time trying to work around
pytest-retry's design choices, I decided to revisit why it was chosen in the first place given its not even mentioned in the pytest docs.I recall that it was chosen because it supported Python 3.8 and
pytest-rerunfailureswas Python 3.9+. However, since then, SQLMesh no longer supports Python 3.8, so in this PR i've switched to usepytest-rerunfailuresand everything suddenly started working correctly.I also cleaned up a bunch of warnings like the following:
and