Fix: Redundant creation of view models during the first evaluation#5337
Merged
izeigerman merged 1 commit intomainfrom Sep 9, 2025
Merged
Fix: Redundant creation of view models during the first evaluation#5337izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where view models were incorrectly triggering empty table creation during evaluation. The fix ensures that empty table creation only applies to materialized models when column types are explicitly provided, preventing redundant view model creation.
- Replaced
model.annotatedcheck with a more specific condition for materialized models - Added logic to verify both materialization type and column type availability
- Updated test assertion to check exact call count rather than just call occurrence
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sqlmesh/core/snapshot/evaluator.py | Added logic to restrict empty table creation to materialized models with known column types |
| tests/core/test_snapshot_evaluator.py | Updated test assertion to verify exact call count for view creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eakmanrq
reviewed
Sep 9, 2025
eakmanrq
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5331
The original intention was to create an empty table first if the user explicitly specified column types. However,
model.annotatedcan returnTruefor VIEW models as well if its types are known statically. This PR makes sure that the empty table creation only applies to materialized models.