Skip to content

Fix: Include root package in search candidates when resolving dbt macros#5349

Merged
vchan merged 3 commits intomainfrom
vchan/fix-macro-dispatch
Sep 24, 2025
Merged

Fix: Include root package in search candidates when resolving dbt macros#5349
vchan merged 3 commits intomainfrom
vchan/fix-macro-dispatch

Conversation

@vchan
Copy link
Contributor

@vchan vchan commented Sep 11, 2025

dbt package macros can be overridden in the root package. This PR includes the root package when searching packages during macro dispatch resolution.

@vchan vchan force-pushed the vchan/fix-macro-dispatch branch from 2bdfabf to cf34616 Compare September 24, 2025 17:16
@vchan vchan force-pushed the vchan/fix-macro-dispatch branch from cf34616 to dcc6d8e Compare September 24, 2025 17:42
@vchan vchan marked this pull request as ready for review September 24, 2025 17:42
Copy link
Contributor

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, to try and summarize: when there's a macro namespace, we now always check the root package first for any possible overrides. And this is bound to change when we take dispatch configs into account.

@vchan vchan merged commit 0bda998 into main Sep 24, 2025
44 of 46 checks passed
@vchan vchan deleted the vchan/fix-macro-dispatch branch September 24, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants