Skip to content

Fix: tests should not be sensitive to output column order#5369

Merged
treysp merged 3 commits intomainfrom
trey/test-partial-order
Sep 18, 2025
Merged

Fix: tests should not be sensitive to output column order#5369
treysp merged 3 commits intomainfrom
trey/test-partial-order

Conversation

@treysp
Copy link
Contributor

@treysp treysp commented Sep 12, 2025

If a test

  1. Is for a model whose query does not contain ORDER BY
  2. Has output rows and specifies the columns in a different order than the query
  3. Has output row values that sort differently depending on which column is sorted by first
  4. Has partial: true

Then test results incorrectly become sensitive to column order due to our automatic sorting.

@treysp treysp requested a review from georgesittas September 12, 2025 23:07
@treysp treysp force-pushed the trey/test-partial-order branch 4 times, most recently from 2ba214e to 71f5ff0 Compare September 16, 2025 17:53
@treysp treysp force-pushed the trey/test-partial-order branch from 71f5ff0 to 2032935 Compare September 17, 2025 13:49
@treysp treysp enabled auto-merge (squash) September 17, 2025 13:50
@treysp treysp force-pushed the trey/test-partial-order branch from 2032935 to 2025902 Compare September 18, 2025 13:47
@treysp treysp merged commit 54e6b57 into main Sep 18, 2025
36 checks passed
@treysp treysp deleted the trey/test-partial-order branch September 18, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants