Skip to content

Fix: Modifying a standalone audit when using the dev-only virtual environment mode#5383

Merged
izeigerman merged 2 commits intomainfrom
fix-dev-only-standalone-audit-change
Sep 16, 2025
Merged

Fix: Modifying a standalone audit when using the dev-only virtual environment mode#5383
izeigerman merged 2 commits intomainfrom
fix-dev-only-standalone-audit-change

Conversation

@izeigerman
Copy link
Collaborator

No description provided.

@izeigerman izeigerman requested review from a team and Copilot September 15, 2025 22:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where modifying a standalone audit in dev-only virtual environment mode would fail. The fix ensures proper handling of snapshot comparisons between models and non-models (like audits) by adding appropriate type checks before evaluating virtual environment mode changes.

  • Adds early type validation to prevent virtual environment mode comparisons on non-models
  • Includes a comprehensive test case that reproduces and validates the fix for standalone audit modifications

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sqlmesh/core/plan/common.py Adds type checking logic to handle model vs non-model snapshot comparisons
tests/core/test_integration.py Adds test case verifying standalone audit modification works correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@izeigerman izeigerman enabled auto-merge (squash) September 15, 2025 22:29
@izeigerman izeigerman merged commit d7dda8f into main Sep 16, 2025
36 checks passed
@izeigerman izeigerman deleted the fix-dev-only-standalone-audit-change branch September 16, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants