Merged
Conversation
Contributor
benfdking
commented
Sep 17, 2025
benfdking
commented
- removes an old pin for uvicorn for the lsp
- was copied as depends on web but uvicorn is not an actual python dep
- removes an old pin for uvicorn for the lsp - was copied as depends on web but uvicorn is not an actual python dep
themisvaltinos
approved these changes
Sep 17, 2025
Contributor
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
what's the reason to comment it out instead of removing it?
Contributor
Author
|
My reasoning is because two lines above I say we copied from web and so want to keep fact, we've copied as such. So this feels more like copied and modified rather than just taken what I want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.