Fix: Dont backfill seeds if the seed data didnt actually change#5398
Merged
Fix: Dont backfill seeds if the seed data didnt actually change#5398
Conversation
izeigerman
reviewed
Sep 18, 2025
sqlmesh/core/plan/builder.py
Outdated
| # seeds with metadata updates should be categorized as forward_only to prevent unnecessary backfill | ||
| # backfill should only happen if the actual seed data changes, in which case it will be classed as | ||
| # directly modified / breaking and not forward only as this code path will not be hit | ||
| forward_only = True |
Collaborator
There was a problem hiding this comment.
Actually, I've realized this might not be necessary. METADATA category already reuses the version
Collaborator
Author
There was a problem hiding this comment.
Oh, you're right. I've simplified this PR
izeigerman
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, a simple metadata change on a seed would trigger it to be recreated / data reloaded:
This PR updates
should_force_rebuildto returnFalseon a seed snapshot if only its metadata changed. This works because snapshots with metadata changes share the physical table with the previous snapshot, meaning:missing_intervals()to return no missing intervals