Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sqlmesh/core/snapshot/evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ def create_snapshot(
rendered_physical_properties=rendered_physical_properties,
allow_destructive_snapshots=allow_destructive_snapshots,
allow_additive_snapshots=allow_additive_snapshots,
run_pre_post_statements=True,
)
else:
is_table_deployable = deployability_index.is_deployable(snapshot)
Expand Down Expand Up @@ -1026,6 +1027,7 @@ def _clone_snapshot_in_dev(
rendered_physical_properties: t.Dict[str, exp.Expression],
allow_destructive_snapshots: t.Set[str],
allow_additive_snapshots: t.Set[str],
run_pre_post_statements: bool = False,
) -> None:
adapter = self.get_adapter(snapshot.model.gateway)

Expand All @@ -1048,6 +1050,7 @@ def _clone_snapshot_in_dev(
rendered_physical_properties=rendered_physical_properties,
allow_destructive_snapshots=allow_destructive_snapshots,
allow_additive_snapshots=allow_additive_snapshots,
run_pre_post_statements=run_pre_post_statements,
)
except Exception:
adapter.drop_table(target_table_name)
Expand Down
49 changes: 49 additions & 0 deletions tests/core/test_snapshot_evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,55 @@ def test_create_prod_table_exists(mocker: MockerFixture, adapter_mock, make_snap
)


def test_pre_hook_forward_only_clone(
mocker: MockerFixture, make_mocked_engine_adapter, make_snapshot
):
"""
Verifies that pre-statements are executed when creating a clone of a forward-only model.
"""
pre_statement = """CREATE TEMPORARY FUNCTION "example_udf"("x" BIGINT) AS ("x" + 1)"""
model = load_sql_based_model(
parse( # type: ignore
f"""
MODEL (
name test_schema.test_model,
kind INCREMENTAL_BY_TIME_RANGE (
time_column ds
)
);

{pre_statement};

SELECT a::int, ds::string FROM tbl;
"""
),
)

snapshot = make_snapshot(model)
snapshot.categorize_as(SnapshotChangeCategory.BREAKING, forward_only=True)
snapshot.previous_versions = snapshot.all_versions

adapter = make_mocked_engine_adapter(EngineAdapter)
adapter.with_settings = lambda **kwargs: adapter
adapter.table_exists = lambda _: True # type: ignore
adapter.SUPPORTS_CLONING = True
mocker.patch.object(
adapter,
"get_data_objects",
return_value=[],
)
mocker.patch.object(
adapter,
"get_alter_operations",
return_value=[],
)

evaluator = SnapshotEvaluator(adapter)

evaluator.create([snapshot], {}, deployability_index=DeployabilityIndex.none_deployable())
adapter.cursor.execute.assert_any_call(pre_statement)


def test_create_only_dev_table_exists(mocker: MockerFixture, adapter_mock, make_snapshot):
model = load_sql_based_model(
parse( # type: ignore
Expand Down