-
Notifications
You must be signed in to change notification settings - Fork 358
Feat!: bring dbt node information through to SQLMesh #5412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1197,6 +1197,9 @@ def metadata_hash(self) -> str: | |
| for k, v in sorted(args.items()): | ||
| metadata.append(f"{k}:{gen(v)}") | ||
|
|
||
| if self.dbt_node_info: | ||
| metadata.append(self.dbt_node_info.json(sort_keys=True)) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need to extend the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added this and I think it's failing in the way you expected it to: This is correct because after the migration in this PR runs and a new plan is made, the extra fields get read from disk and show as a metadata change because they go from being empty in state to being populated in state |
||
|
|
||
| metadata.extend(self._additional_metadata) | ||
|
|
||
| self._metadata_hash = hash_data(metadata) | ||
|
|
@@ -3019,6 +3022,7 @@ def render_expression( | |
| "formatting": str, | ||
| "optimize_query": str, | ||
| "virtual_environment_mode": lambda value: exp.Literal.string(value.value), | ||
| "dbt_node_info_": lambda value: value.to_expression(), | ||
| } | ||
|
|
||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.