fix: bigquery snowflake source columns support#5428
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/snowflake_bigquery_source_columns_support
branch
from
e68fd6c to
47e57a2
Compare
eakmanrq
force-pushed
the
eakmanrq/snowflake_bigquery_source_columns_support
branch
4 times, most recently
from
928170d to
acd87c8
Compare
eakmanrq
commented
Sep 23, 2025
Comment on lines
+490
to
+496
| df = pd.DataFrame( | ||
| { | ||
| "id": [1, 2, 3], | ||
| "ts": ["2025-01-01 00:00:00", "2025-01-01 00:00:00", "2025-01-01 00:00:00"], | ||
| "val": [7, 8, 9], | ||
| } | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
The actual values in the dataframe didn't matter before so they just had placeholder values but due to the ordering check they are now updated to match what we claim the structure is in the merge call.
eakmanrq
force-pushed
the
eakmanrq/snowflake_bigquery_source_columns_support
branch
from
acd87c8 to
9feefcf
Compare
eakmanrq
force-pushed
the
eakmanrq/snowflake_bigquery_source_columns_support
branch
from
9feefcf to
2420feb
Compare
izeigerman
approved these changes
Sep 23, 2025
eakmanrq
deleted the
eakmanrq/snowflake_bigquery_source_columns_support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataframe tests were accidentally disabled in this PR: #5117
This was then fixed in this PR: #5423
Which then exposed this issue. Therefore this PR fixes support for ignored changes for BQ and Snowflake using Pandas.
Confirmed CI checks for Snowflake/BQ pass.