Chore: Break up the core integration tests#5432
Merged
izeigerman merged 4 commits intomainfrom Sep 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request breaks up the core integration tests into separate, more focused modules. The changes aim to improve test organization and maintainability by separating different types of integration tests.
- Extracts utility functions into a shared
utils.pymodule - Separates tests into focused modules:
test_run.py,test_restatement.py,test_plan.py,test_multi_repo.py, andtest_model_kinds.py - Maintains test functionality while improving code organization
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/core/integration/utils.py | New module containing shared utility functions for integration tests |
| tests/core/integration/test_run.py | Tests for run functionality extracted from main integration tests |
| tests/core/integration/test_restatement.py | Tests for restatement functionality extracted from main integration tests |
| tests/core/integration/test_plan.py | Tests for plan functionality extracted from main integration tests |
| tests/core/integration/test_multi_repo.py | Tests for multi-repository functionality extracted from main integration tests |
| tests/core/integration/test_model_kinds.py | Tests for various model kinds functionality extracted from main integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
izeigerman
commented
Sep 23, 2025
| @@ -0,0 +1,1939 @@ | |||
| from __future__ import annotations | |||
Collaborator
Author
There was a problem hiding this comment.
This will likely become the next candidate for breakup due to the vagueness of its scope. I’m looking for feedback on how to improve it
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6cb434c to
3046be2
Compare
eakmanrq
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.