Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlmesh/dbt/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _lowercase_name(cls, v: str) -> str:

@property
def canonical_name(self) -> str:
return f"{self.package_name}.{self.name}" if self.package_name else self.name
return f"{self.package_name}.{self.name}".lower() if self.package_name else self.name

@property
def is_standalone(self) -> bool:
Expand Down
25 changes: 25 additions & 0 deletions tests/dbt/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,31 @@ def test_test_to_sqlmesh_fields():
assert audit.dialect == "bigquery"


def test_test_config_canonical_name():
test_config_upper_case_package = TestConfig(
name="foo_test",
package_name="TEST_PACKAGE",
sql="SELECT 1",
)

assert test_config_upper_case_package.canonical_name == "test_package.foo_test"

test_config_mixed_case_package = TestConfig(
name="Bar_Test",
package_name="MixedCase_Package",
sql="SELECT 1",
)

assert test_config_mixed_case_package.canonical_name == "mixedcase_package.bar_test"

test_config_no_package = TestConfig(
name="foo_bar_test",
sql="SELECT 1",
)

assert test_config_no_package.canonical_name == "foo_bar_test"


def test_singular_test_to_standalone_audit(dbt_dummy_postgres_config: PostgresConfig):
sql = "SELECT * FROM FOO.BAR WHERE cost > 100"
test_config = TestConfig(
Expand Down