Closed
Conversation
eakmanrq
force-pushed
the
eakmanrq/unicode_support
branch
from
d1c4453 to
34a5862
Compare
Collaborator
Author
|
Views don't get santiized. Therefore just the underlying tables get their unicode characters replaced which is still not optimal but not worth making this breaking change for users at this time. |
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING: If users currently have unicode characters then their table name will update to actually include the unicode name. Still thinking through how to migrate this.
This PR affects
santize_namefunction would before would replace unicode characters with underscores. This is used for populating the file cache and creating table names. Therefore someone could have had a SQLMesh project that would run but it would not have correct names and they could get conflicts when reading from cache or writing.Therefore this PR updates
sanitize_nameto maintain the unicode characters while still removing things like double quotes from the resulting name.