fix: parse column from cast expression for ScdType2 models#5475
Merged
fix: parse column from cast expression for ScdType2 models#5475
Conversation
eakmanrq
reviewed
Oct 2, 2025
| if v is None: | ||
| return None | ||
| parsed = d.parse_one(v) | ||
| if isinstance(parsed, exp.Cast) and isinstance(parsed.this, exp.Column): |
Collaborator
There was a problem hiding this comment.
Can you add a comment explaining that both scd type 2 expects a column and the logic for it does a cast anyways so this shouldn't be needed? Could be an issue later so it would at least explaining the reasoning at this time.
Contributor
Author
There was a problem hiding this comment.
updated with:
"""
Extract column name if updated_at contains a cast.
SCDType2ByTimeKind and SCDType2ByColumnKind expect a column, and the casting is done later.
"""
eakmanrq
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.