fix: ensure _get_data_objects respects snapshots with different schem…#5515
Merged
themisvaltinos merged 3 commits intoSQLMesh:mainfrom Oct 16, 2025
Merged
fix: ensure _get_data_objects respects snapshots with different schem…#5515themisvaltinos merged 3 commits intoSQLMesh:mainfrom
themisvaltinos merged 3 commits intoSQLMesh:mainfrom
Conversation
z3z1ma
force-pushed
the
fix/get-data-objects
branch
from
a38d982 to
0c79100
Compare
z3z1ma
force-pushed
the
fix/get-data-objects
branch
from
0c79100 to
b8b983a
Compare
themisvaltinos
approved these changes
Oct 16, 2025
Contributor
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
simplified the lookup to not mismatch catalogs and fixed the failing tests to unblock you @z3z1ma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…a or catalog.
this is enough for get data objects in the snapshot evaluator to think a table doesn't exist, which causes cascading issues (as you'd expect) with, for example, skipping
SnapshotEvaluator.migratein situations where the table did in fact exist. This causes issues with downstream tables which expect a correct schema when doing CTAS and such. Its a hard to diagnose breakage without a lot of fishing.