Skip to content

fix: dbt as_bool and as_number filters should return their original input values#5532

Merged
newtonapple merged 1 commit intomainfrom
ddai/fix-dbt-as_bool
Oct 15, 2025
Merged

fix: dbt as_bool and as_number filters should return their original input values#5532
newtonapple merged 1 commit intomainfrom
ddai/fix-dbt-as_bool

Conversation

@newtonapple
Copy link
Contributor

This matches dbt's TEXT_FILTERS implementation.

@erindru
Copy link
Collaborator

erindru commented Oct 12, 2025

On the dbt side, does the Jinja environment usually get constructed with native=False?

I notice there is a different codepath that decides if NATIVE_FILTERS or TEXT_FILTERS is used, and NATIVE_FILTERS implements as_bool / as_number slightly differently

@newtonapple newtonapple enabled auto-merge (squash) October 14, 2025 22:38
@newtonapple newtonapple merged commit 03309b4 into main Oct 15, 2025
35 of 36 checks passed
@newtonapple newtonapple deleted the ddai/fix-dbt-as_bool branch October 15, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants