Fix(table_diff): Widen the data types that --decimals applies to#5542
Merged
Fix(table_diff): Widen the data types that --decimals applies to#5542
Conversation
ef54177 to
55f376f
Compare
izeigerman
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this,
sqlmesh table_diff ... --decimals nwould:--decimalsto columns of typeDOUBLEorFLOAT. I believe the reason was historical - it is assumed that floating point numbers are always awkward so you have to round them to some fixed length out of necessity, but if you're using fixed point numbers then you don't need this so the whole number should be comparedROUNDfunction that works with floating point types (Postgres is a notable example that does not)So this PR:
--decimalsto apply to any column that can contain a fixed or floating point decimalEngineAdapter._normalize_decimal_valueto produce the value to compare instead of wrapping it inROUND()and hoping that is valid on the target database