Fix: create_test error with query and CTEs included#5559
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error in the create_test function when working with queries that include CTEs. The fix involves adding a default value to the pandas_timestamp_to_pydatetime function and updating how it's called to use explicit keyword arguments.
- Added default value
Noneto thecolumns_to_typesparameter - Updated function call to use explicit keyword argument
df=instead of positional argument
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sqlmesh/utils/date.py | Added default value None to columns_to_types parameter in pandas_timestamp_to_pydatetime function |
| sqlmesh/core/test/definition.py | Updated function call to use keyword argument and removed the second positional argument |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
georgesittas
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5550