Skip to content

Fixes failing Release build #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barulicm merged 2 commits into from
Oct 12, 2025
Merged

Fixes failing Release build #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b557f2c
Adds `reserve` workaround for compiler static analysis bug.
barulicm Oct 12, 2025
a54363d
Puts PR validation builds in Release mode
barulicm Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ jobs:
shell: bash
run: |
source /opt/ros/jazzy/setup.bash
colcon build --packages-up-to ${{ steps.get-changed-packages.outputs.changed-packages }}
colcon build --packages-up-to ${{ steps.get-changed-packages.outputs.changed-packages }} --cmake-args -DCMAKE_BUILD_TYPE=Release

- name: Build Above Changes
if: ${{ steps.get-changed-packages.outputs.changed-packages != '' }}
shell: bash
run: |
source /opt/ros/jazzy/setup.bash
colcon build --packages-above-and-dependencies ${{ steps.get-changed-packages.outputs.changed-packages }}
colcon build --packages-above-and-dependencies ${{ steps.get-changed-packages.outputs.changed-packages }} --cmake-args -DCMAKE_BUILD_TYPE=Release

- name: Test Changed Packages
shell: bash
Expand Down
1 change: 1 addition & 0 deletions ateam_kenobi/src/plays/stop_plays/stop_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ bool isPointInOrBehindGoal(
std::vector<ateam_geometry::AnyShape> getAddedObstacles(const World & world)
{
std::vector<ateam_geometry::AnyShape> obstacles;
obstacles.reserve(3);

const auto half_field_length = world.field.field_length / 2.0;
const auto half_goal_width = world.field.goal_width / 2.0;
Expand Down