Implement GET /v1/trades/tx/{tx_hash} endpoint

AGENTS.md

@@ -18,3 +18,4 @@
 - All API errors must go through the `ApiError` enum, never return raw status codes
 - Keep OpenAPI annotations (`#[utoipa::path(...)]`) in sync when adding or modifying routes
 - Do not commit `.env` or secrets; use `.env.example` for documenting env vars
+- Use the `address!` macro from `alloy::primitives` for creating `Address` constants instead of parsing from strings

Cargo.toml

@@ -30,4 +30,5 @@ rain_orderbook_common = { path = "lib/rain.orderbook/crates/common", default-fea
 rain_orderbook_app_settings = { path = "lib/rain.orderbook/crates/settings", default-features = false }
 rain_orderbook_bindings = { path = "lib/rain.orderbook/crates/bindings", default-features = false }
 rain-math-float = { path = "lib/rain.orderbook/lib/rain.interpreter/lib/rain.interpreter.interface/lib/rain.math.float/crates/float" }
+futures = "0.3"
 wasm-bindgen = "=0.2.100"

src/error.rs

@@ -32,6 +32,8 @@ pub enum ApiError {
     Internal(String),
     #[error("Rate limited: {0}")]
     RateLimited(String),
+    #[error("Not yet indexed: {0}")]
+    NotYetIndexed(String),
 }
 
 impl<'r> Responder<'r, 'static> for ApiError {
@@ -42,6 +44,7 @@ impl<'r> Responder<'r, 'static> for ApiError {
             ApiError::NotFound(msg) => (Status::NotFound, "NOT_FOUND", msg.clone()),
             ApiError::Internal(msg) => (Status::InternalServerError, "INTERNAL_ERROR", msg.clone()),
             ApiError::RateLimited(msg) => (Status::TooManyRequests, "RATE_LIMITED", msg.clone()),
+            ApiError::NotYetIndexed(msg) => (Status::Accepted, "NOT_YET_INDEXED", msg.clone()),
         };
         let span = request_span_for(req);
         span.in_scope(|| {
@@ -52,6 +55,13 @@ impl<'r> Responder<'r, 'static> for ApiError {
                     error_message = %message,
                     "request failed"
                 );
+            } else if matches!(self, ApiError::NotYetIndexed(_)) {
+                tracing::info!(
+                    status = status.code,
+                    code = %code,
+                    error_message = %message,
+                    "transaction not yet indexed"
+                );
             } else {
                 tracing::warn!(
                     status = status.code,

src/main.rs

@@ -49,8 +49,8 @@ impl Modify for SecurityAddon {
         routes::order::post_order_cancel,
         routes::orders::get_orders_by_tx,
         routes::orders::get_orders_by_address,
-        routes::trades::get_trades_by_tx,
-        routes::trades::get_trades_by_address,
+        routes::trades::get_by_tx::get_trades_by_tx,
+        routes::trades::get_by_address::get_trades_by_address,
     ),
     components(),
     modifiers(&SecurityAddon),

src/routes/trades/get_by_address.rs

@@ -0,0 +1,45 @@
+use crate::auth::AuthenticatedKey;
+use crate::error::{ApiError, ApiErrorResponse};
+use crate::fairings::{GlobalRateLimit, TracingSpan};
+use crate::types::common::ValidatedAddress;
+use crate::types::trades::{TradesByAddressResponse, TradesPaginationParams};
+use rocket::serde::json::Json;
+use rocket::State;
+use tracing::Instrument;
+
+#[utoipa::path(
+    get,
+    path = "/v1/trades/{address}",
+    tag = "Trades",
+    security(("basicAuth" = [])),
+    params(
+        ("address" = String, Path, description = "Owner address"),
+        TradesPaginationParams,
+    ),
+    responses(
+        (status = 200, description = "Paginated list of trades", body = TradesByAddressResponse),
+        (status = 400, description = "Bad request", body = ApiErrorResponse),
+        (status = 401, description = "Unauthorized", body = ApiErrorResponse),
+        (status = 429, description = "Rate limited", body = ApiErrorResponse),
+        (status = 500, description = "Internal server error", body = ApiErrorResponse),
+    )
+)]
+#[get("/<address>?<params..>", rank = 2)]
+pub async fn get_trades_by_address(
+    _global: GlobalRateLimit,
+    _key: AuthenticatedKey,
+    raindex: &State<crate::raindex::RaindexProvider>,
+    span: TracingSpan,
+    address: ValidatedAddress,
+    params: TradesPaginationParams,
+) -> Result<Json<TradesByAddressResponse>, ApiError> {
+    async move {
+        tracing::info!(address = ?address, params = ?params, "request received");
+        raindex
+            .run_with_client(move |_client| async move { todo!() })
+            .await
+            .map_err(ApiError::from)?
+    }
+    .instrument(span.0)
+    .await
+}