Implement GET /v1/trades/{address} endpoint#51
Open
findolor wants to merge 1 commit intoimplement-trades-tx-hashfrom
Open
Implement GET /v1/trades/{address} endpoint#51findolor wants to merge 1 commit intoimplement-trades-tx-hashfrom
findolor wants to merge 1 commit intoimplement-trades-tx-hashfrom
Conversation
Add paginated trades-by-owner-address endpoint with unified TradesDataSource trait, update rain.orderbook submodule with owner trades queries and address casing fix.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PRs
Motivation
See issues:
Add a paginated endpoint to retrieve all trades for a given owner address across all configured orderbooks, with optional time filtering. Replaces #40, which was based on the old chain (#39) and couldn't merge cleanly. This branch is rebased on top of
implement-trades-tx-hash(PR #50).Solution
GET /v1/trades/{address}with pagination (page,pageSize) and optional time filters (startTime,endTime)TradesDataSourcetrait withget_trades_for_ownermethod that iterates all configured orderbooks and aggregates trades and total countsRaindexTradesDataSourceviarun_with_client, convertingTradesPaginationParamsintoPaginationParams+TimeFilterwith overflow validationRaindexTradeintoTradeByAddressresponse type (tx_hash, formatted amounts,TokenReffor input/output tokens, order_hash, timestamp, block_number)div_ceil, has_more)rain.orderbooksubmodule (ff9578c→a612a4f) to bring inget_trades_for_owner(),RaindexTradesListResult,PaginationParams,TimeFilter,OrderbookIdentifierParams, and address casing fixget_by_tx.rsmock to implement the new trait methodChecks
By submitting this for review, I'm confirming I've done the following:
fix #29