"Round Profile Pictures" update to feature version 2#494
"Round Profile Pictures" update to feature version 2#494
Conversation
rgantzos
left a comment
rgantzos
left a comment
There was a problem hiding this comment.
You updated the features.json file for multiple features.
rgantzos
left a comment
rgantzos
left a comment
There was a problem hiding this comment.
Could you please also delete the old round-profile-pictures.js file?
| "tags": [], | ||
| "scripts": [{ "file": "script.js", "runOn": "/*" }], | ||
| "options": [ | ||
| { "id": "Rounding Percentage", "name": "Rounding Percentage", "default": "50%" } |
There was a problem hiding this comment.
If we're going to add things like this, then we should also add an option validation system.
There was a problem hiding this comment.
I'll make an issue for this and it should be added in the next few days.
There was a problem hiding this comment.
@Wilamaxin It's been merged, something like "validation":[{ "regex": "^(100(?:\\.0{1,2})?|\\d{1,2}(?:\\.\\d{1,2})?)%$", "explanation": "Percentage must be between 0% and 100%."}] for the option would work now.
There was a problem hiding this comment.
I feel like this would work better as CSS. Options create CSS variables, so something such as img[src*="/get_image/user/"] should work as a selector, and then the CSS variable could just be used for roundness.
| "id": "round-profile-pictures", | ||
| "version": 2 |
There was a problem hiding this comment.
This feature was previously bugged and has a few super cool new changes with this update, so let's move this to the top of the list as well.
rgantzos
added
type: enhancement
rgantzos
added
status: needs review
2 participants
Additional changes:
Added an option in settings to allow the user to choose the level of rounding percentage.
Fixed broken rounded edges of profile pictures in the "What's Happening?" box.
Before:
After: