fix(target): detect target changes and rebind handlers#19
Merged
Conversation
Previously, changing the `target` prop without changing handler keys would not trigger a rebind - the listeners would remain on the old target. Now the component compares resolved targets and rebinds when they differ. Also adds GitHub Actions CI workflow for lint, test, and build across Node 18, 20, and 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetprop without changing handler keys would not trigger a rebindChanges
componentDidUpdatenow compares resolved targets usinggetTarget(prevProps) !== getTarget(this.props)Test plan