Skip to content

ci: fix tree-sitter compilation on CI #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbaoFromCUG merged 1 commit into from
Jan 7, 2026
Merged

ci: fix tree-sitter compilation on CI #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
name: CI
on:
push:
branches: master
pull_request:
branches: "*"
branches:
- "master"
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
cancel-in-progress: true
jobs:
lint:
Expand All @@ -27,15 +26,21 @@ jobs:
pnpm i
pnpm run lint:check
unit_test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
rev: [nightly, stable, v0.10.4]
cc: [gcc]
rev: [nightly, stable]
runs-on: ${{ matrix.os }}
env:
CC: ${{ matrix.cc }}
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v3
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/setup-node@v3 action is used without specifying a node-version parameter. This means the workflow will use whatever Node.js version is pre-installed on the runner, which could vary or change over time and lead to inconsistent builds. Consider pinning to a specific Node.js version for reproducibility.

Suggested change
- uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 20

Copilot uses AI. Check for mistakes.
- name: Install tree-sitter CLI
run: npm i -g tree-sitter-cli
- name: Install neovim
uses: rhysd/action-setup-vim@v1
with:
Expand All @@ -44,9 +49,6 @@ jobs:
- name: Test the extension with Neovim
run: |
set -eux
rm -rf .tests
ls -lah
cat scripts/minimal_init.lua
make test
build:
runs-on: ubuntu-latest
Expand Down
5 changes: 0 additions & 5 deletions .husky/pre-commit
View file
Open in desktop

This file was deleted.

7 changes: 1 addition & 6 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,10 @@ export default antfu({
yaml: false,
markdown: false,
typescript: true,
gitignore: true,
}, {
rules: {
'no-console': 'off',
'style/semi': ['error', 'always'],
},
ignores: [
'node_modules',
'dist',
'coverage',
'**/*.d.ts',
],
});
39 changes: 10 additions & 29 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,18 @@
"build:lib:prod": "tsc",
"clean": "pnpm clean:lib",
"clean:lib": "rimraf lib tsconfig.tsbuildinfo",
"clean:lintcache": "rimraf .eslintcache .stylelintcache",
"clean:lintcache": "rimraf .eslintcache",
"clean:labextension": "rimraf neopyter/labextension neopyter/_version.py",
"clean:all": "pnpm clean:lib && pnpm clean:labextension && pnpm clean:lintcache",
"eslint": "pnpm eslint:check --fix",
"eslint:check": "eslint . --cache",
"install:extension": "pnpm build",
"lint": "pnpm stylelint && pnpm eslint",
"lint:check": "pnpm stylelint:check && pnpm eslint:check",
"stylelint": "pnpm stylelint:check --fix",
"stylelint:check": "stylelint --cache \"style/**/*.css\"",
"lint": "pnpm eslint",
"lint:check": "pnpm eslint:check",
"test": "jest --coverage",
"watch": "run-p watch:src watch:labextension",
"watch:src": "tsc -w --strict false --sourceMap",
"watch:labextension": "jupyter labextension watch .",
"prepare": "husky install"
"watch:labextension": "jupyter labextension watch ."
},
"dependencies": {
"@jupyterlab/application": "^4.3.4",
Expand All @@ -87,7 +84,7 @@
"zustand": "^4.5.5"
},
"devDependencies": {
"@antfu/eslint-config": "^3.12.0",
"@antfu/eslint-config": "^6.7.3",
"@jupyterlab/builder": "^4.3.4",
"@jupyterlab/codeeditor": "^4.3.4",
"@jupyterlab/completer": "^4.3.4",
Expand All @@ -101,15 +98,10 @@
"@lumino/disposable": "^2.1.3",
"@types/jest": "^29.5.14",
"@types/json-schema": "^7.0.15",
"eslint": "^9.17.0",
"husky": "^8.0.3",
"eslint": "^9.39.2",
"jest": "^29.7.0",
"lint-staged": "^15.2.11",
"npm-run-all": "^4.1.5",
"rimraf": "^5.0.10",
"stylelint": "^15.11.0",
"stylelint-config-recommended": "^13.0.0",
"stylelint-config-standard": "^34.0.0",
"ts-jest": "^29.2.5",
"typescript": "^5.7.2",
"yjs": "^13.6.21"
Expand All @@ -123,20 +115,9 @@
"schemaDir": "schema",
"outputDir": "neopyter/labextension"
},
"stylelint": {
"extends": [
"stylelint-config-recommended",
"stylelint-config-standard"
],
"rules": {
"property-no-vendor-prefix": null,
"selector-no-vendor-prefix": null,
"value-no-vendor-prefix": null
}
},
"lint-staged": {
"*.py": "ruff format",
"*.css": "pnpm stylelint",
"*.{json,js,jsx,ts,tsx}": "pnpm eslint"
"pnpm": {
"onlyBuiltDependencies": [
"@fortawesome/fontawesome-free"
]
}
}
Loading
Loading