Fix memory corruption, related to unitialized currentPlay#16
Open
falkTX wants to merge 3 commits intoSVModular:v2.0from
Open
Fix memory corruption, related to unitialized currentPlay#16falkTX wants to merge 3 commits intoSVModular:v2.0from
falkTX wants to merge 3 commits intoSVModular:v2.0from
Conversation
Signed-off-by: falkTX <falktx@falktx.com>
Closed
Collaborator
|
thanks! I still have been unable to reproduce the issue on macOS. I will give this a run in the next day or so and merge if it looks good. |
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain conditions, loading a project with DrumKit Sequencer on it would cause a crash.
Main issue seems to be that
currentPlayis not initialized during constructor, so random stuff would just go wrong..See related discussion at DISTRHO/Cardinal#225
Patch fixes the crash, reordering some minor things for looking better and also in a way that makes sense.