feat : 모임 입장하기 api 추가 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
개요새로운 참가자 입장 기능을 추가합니다. 조인 페이지에 폼 제출, 오류 처리, 상태 지속성 메커니즘을 구현하고, API 타입을 정의하며, 공유 페이지 네비게이션 링크를 업데이트합니다. 변경사항
예상 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~10분 관련 가능성이 있는 PR
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@app/join/`[id]/page.tsx:
- Around line 23-41: In handleSubmit (the submit handler) when persisting the
userId based on isRemembered, also remove the userId from the opposite storage
so stale values don't persist: if isRemembered is true, set
localStorage.setItem('userId', name) and remove
sessionStorage.removeItem('userId'); otherwise set
sessionStorage.setItem('userId', name) and remove
localStorage.removeItem('userId'); update the logic inside the try block where
participantEnter.mutateAsync result.success is handled to perform these paired
set/remove operations for userId.
In `@app/share/`[id]/page.tsx:
- Around line 85-87: The share button’s visual Link uses `/join/${id}` but the
copied URL is built with `/meeting/${id}`, causing inconsistent share paths;
update the code that generates the copied share URL (the function or variable
that composes the share link—e.g., any `copyMeetingLink`, `generateShareUrl`,
`shareUrl` or copy handler) to use `/join/${id}` so it matches the Link href and
the join flow, and ensure the `id` interpolation and origin are reused rather
than a different path.
Comment on lines
85
to
87
| <Link | ||
| href={`/meeting/${id}`} | ||
| href={`/join/${id}`} | ||
| className="bg-blue-5 hover:bg-blue-8 h-12 w-full rounded-sm py-2.5 pt-3 text-center text-lg font-normal text-white transition-colors md:w-90" |
There was a problem hiding this comment.
공유 링크 경로를 CTA와 일치시키세요.
버튼은 /join/{id}로 이동하지만, 복사되는 링크는 /meeting/{id}라서 공유 경로가 분리됩니다. join 흐름을 기준으로 복사 링크도 동일하게 맞춰주세요.
🔧 수정 제안
- setShareUrl(`${window.location.origin}/meeting/${id}`);
+ setShareUrl(`${window.location.origin}/join/${id}`);🤖 Prompt for AI Agents
In `@app/share/`[id]/page.tsx around lines 85 - 87, The share button’s visual Link
uses `/join/${id}` but the copied URL is built with `/meeting/${id}`, causing
inconsistent share paths; update the code that generates the copied share URL
(the function or variable that composes the share link—e.g., any
`copyMeetingLink`, `generateShareUrl`, `shareUrl` or copy handler) to use
`/join/${id}` so it matches the Link href and the join flow, and ensure the `id`
interpolation and origin are reused rather than a different path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 모임 입장하기 api 추가
📝 변경사항
모임 입장 API 연동 (
POST /api/participant/{meetingId}/enter)app/join/[id]/page.tsx,hooks/api/useParticipant.tsuseParticipantEnter)localStorage에 저장sessionStorage에 저장/meeting/{meetingId}로 이동✅ 체크리스트
📸 스크린샷
💬 리뷰어 전달사항
Summary by CodeRabbit
릴리스 노트
새로운 기능
버그 수정