Batsheva/display settings#140
Open
BatshevaTavger wants to merge 179 commits intomongo/design-settings-pagefrom
Open
Batsheva/display settings#140BatshevaTavger wants to merge 179 commits intomongo/design-settings-pagefrom
BatshevaTavger wants to merge 179 commits intomongo/design-settings-pagefrom
Conversation
BatshevaTavger
requested review from
EA171,
SariGlick and
e171271
as code owners
moriya2004
approved these changes
Aug 7, 2024
e171271
requested changes
Aug 11, 2024
|
|
||
| .App-link { | ||
| color: #61dafb; | ||
| /* color: #a2ff00; */ |
| import Footer from './stories/footer/FooterComponent'; | ||
| import { SnackbarProvider } from 'notistack'; | ||
| import './App.scss'; | ||
| import { ThemeProvider} from './themes/ThemeProvider.jsx' |
| align-items: center; | ||
| justify-content: center; | ||
| font-size: calc(10px + 2vmin); | ||
| color: white; |
Collaborator
There was a problem hiding this comment.
please remove all comments and use scss structure
| import axios from 'axios'; | ||
|
|
||
| const url = process.env.REACT_APP_SERVER_URL; | ||
| const url = process.env.REACT_APP_BASE_URL; |
Collaborator
There was a problem hiding this comment.
why do you use client url in axios middleware?
| import { useTranslation } from 'react-i18next'; | ||
| import Select from '../../stories/Select/Select.jsx'; | ||
| import CONSTANTS from './constantSetting.js'; | ||
| import './DisplaySettings.scss'; |
| req.body.profileImage = req.file.originalname; | ||
|
|
||
|
|
||
| // שינוי פורמט התאריך, נניח אם יש שדה בשם date |
Collaborator
There was a problem hiding this comment.
comments for explanation should be in english
| if(!mongoose.Types.ObjectId.isValid(id)) | ||
| return next({message:'id is not valid'}) | ||
| if (!mongoose.Types.ObjectId.isValid(id)) | ||
| return next({ message: 'id is not valid' }); |
| } catch (err) { | ||
| console.error(err); | ||
| next({message:err.message,status:500}) | ||
| next({ message: err.message, status: 500 }); |
| res.json(visitedWebsites); | ||
| } catch (err) { | ||
| next({message:err.message,status:500}) | ||
| res.status(500).json({ message: err.message }); |
Collaborator
There was a problem hiding this comment.
please remove all necessary mp3 and jpg files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the DisplaySettings component, allowing users to change the website's theme and the location of popup notifications. The component includes options for theme selection and notification location with translation support.