Open
Conversation
…_saveInCookies
e171271
requested changes
Aug 11, 2024
extension-ui/background.js
Outdated
| chrome.runtime.onStartup.addListener(() => initializeBlockedSitesCache()); | ||
| chrome.runtime.onInstalled.addListener(() => initializeBlockedSitesCache()); | ||
| function fetchUserData() { | ||
| fetch('http://localhost:5000/users/me', { |
Collaborator
There was a problem hiding this comment.
you should have a variable with baseUrl
Collaborator
There was a problem hiding this comment.
this is not baseUrl what you did... it's fullUrl.
you should have http://localhost:5000 in the base variable
extension-ui/popup.html
Outdated
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Extension Popup</title> | ||
| <style> | ||
| body { |
Collaborator
There was a problem hiding this comment.
- move all styles to separate scss file
- all colors should be defined in variables file
- all values should be defined with % instead of px
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i add function that in the plugin send api request to get id for the current user she used with cookie