Open
Conversation
Chani-Pielet
requested review from
EA171,
SariGlick and
e171271
as code owners
estush
approved these changes
Sep 5, 2024
SariGlick
requested changes
Sep 5, 2024
| @@ -0,0 +1,43 @@ | |||
| import React from 'react'; | |||
| import { Box, LinearProgress } from '@mui/material'; | |||
| import './PasswordStrength.scss'; | |||
Owner
There was a problem hiding this comment.
reorder the imports, style files should be the last ones
Collaborator
Author
There was a problem hiding this comment.
קשור לאפרת הרטמן
| } | ||
|
|
||
| .password-strength-meter { | ||
| height: 10px; |
Collaborator
Author
There was a problem hiding this comment.
קשור לאפרת הרטמן
| height: 10px; | ||
| border-radius: 5px; | ||
| right: 3%; | ||
| background-color: #D3D3D3; |
Owner
There was a problem hiding this comment.
colors should be saved in variable, fix all occurrences
Collaborator
Author
There was a problem hiding this comment.
קשור לאפרת הרטמן
| } | ||
|
|
||
| .password-strength-message { | ||
| margin-top: 1px; |
Collaborator
Author
There was a problem hiding this comment.
קשור לאפרת הרטמן
| @@ -0,0 +1,149 @@ | |||
| import React, { useEffect, useState } from 'react'; | |||
| import { useDispatch, useSelector } from 'react-redux'; | |||
| // import ReCAPTCHA from 'react-google-recaptcha'; | |||
Collaborator
Author
There was a problem hiding this comment.
בקוד של אפרת יש את זה כשזה עובד. זה אמור להיות באמת בקוד. למחוק? או להשאיר בהערה?
| { value: 1, text: "edit user profile", iconSrc: '/images/pencil.svg' }, | ||
| { value: 2, text: "manage notifications", iconSrc: 'images/notification.svg' }, | ||
| ]} | ||
| title="edit user" |
Owner
There was a problem hiding this comment.
move all texts to constants file
| return next(error); | ||
| } | ||
| if (same) { | ||
| user.password = "****"; |
Collaborator
Author
There was a problem hiding this comment.
קשור לאפרת הרטמן
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.