Skip to content

Align test expectation with sample scaling and silence backend warnings#218

Merged
SauersML merged 1 commit intomainfrom
codex/fix-pca-fit-consistency-test-and-warnings
Sep 24, 2025
Merged

Align test expectation with sample scaling and silence backend warnings#218
SauersML merged 1 commit intomainfrom
codex/fix-pca-fit-consistency-test-and-warnings

Conversation

@SauersML
Copy link
Owner

Summary

  • expect the Linfa consistency test to use the sample-standardized explained variance and drop an unnecessary mutable binding
  • scope ndarray backend imports so they are only pulled in for non-faer builds and mark helper items to avoid dead-code warnings when faer is active

Testing

  • cargo test --test pca_tests
  • cargo check --all-features (fails: intel-mkl build script redefines MKL_CONFIG)

https://chatgpt.com/codex/tasks/task_e_68d3821db36c832ebce0fae02e667590

@SauersML SauersML merged commit 5751114 into main Sep 24, 2025
5 checks passed
@SauersML SauersML deleted the codex/fix-pca-fit-consistency-test-and-warnings branch September 24, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant