Skip to content

Conversation

@Willy-Chan
Copy link
Collaborator

Thunderkittens backend support, but with a simplified load_inline() implementation.

This turns out to be much simpler than using separate files, but has its own tradeoffs and implications.

Also, users don't have to put the TK repo in the root directory, it's automatically cloned to the Modal.

@willhu-jpg
Copy link
Collaborator

willhu-jpg commented Dec 31, 2025

We should add instructions for installing the TK dir in local environments to the README. Think there's also a mismatch with the CUDA version in the current TK repo too. It's hard coded to 12.6 if we rely on TK instructions to call 'source env.src'

@Willy-Chan
Copy link
Collaborator Author

Willy-Chan commented Jan 1, 2026

We should add instructions for installing the TK dir in local environments to the README. Think there's also a mismatch with the CUDA version in the current TK repo too. It's hard coded to 12.6 if we rely on TK instructions to call 'source env.src'

@willhu-jpg Added instructions to the README, lmk what you think. Also, could you clarify the CUDA version point? Like the tk-v2 branch uses a different version than kernelbench right now?

@willhu-jpg
Copy link
Collaborator

README changes look good. For the CUDA version, checkout the env.src in the TK repo. Typical setup is to call "source env.src" to set all the environment variables, but they have it hardcoded to 12.6.

@willhu-jpg willhu-jpg self-requested a review January 2, 2026 03:03
Copy link
Collaborator

@willhu-jpg willhu-jpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good otherwise! let's merge it :)

README.md Outdated
tk_root = os.environ.get("THUNDERKITTENS_ROOT", "/root/ThunderKittens")
```

This allows the kernel to include the right TK primitives.s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit typo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, fixed the typo. @simonguozirui TK works on CUDA versions 12.6 - 12.9, rn in modal scripts the system uses CUDA 12.8 by default which should be fine. Locally users will set CUDA_HOME, default is 12.6 for TK's env.src. Lmk if this arrangement sounds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants