Model lists as Lists of NonNull elements

[cysp]

contentful#48 but for our fork. 🙃

[petronbot]

LGTM

[ianhowe76]

👍

[ghost]

How is this handled in the native GraphQL implementation?

[cysp]

It's a schema definition concern rather than an implementation difference, this is changing the definition of lists of entries from [EntryType] to [EntryType!], indicating that while the list can itself be null or empty, none of its elements will be null.

I've done some testing in the development space with the lists of occurrences for an event and it looks like the existing implementation filters out unpublished entries already, it just doesn't reflect that in the schema definition. So I think that this won't result in breakage.

[cysp]

Concretely, querying the occurrences for this event x74vyp9vlegq:1wGth51Ko4C8EOeGU0wSoo results in a list of occurrences two elements long, despite the entry referencing multiple unpublished occurrences.

[cysp]

Haha I just went to merge this but realised that I can't because I don't have write access. ☹️