refactor: refactor job_v3 handlebar helper#1936
Draft
sbliven wants to merge 1 commit intoSciCatProject:masterfrom
Draft
refactor: refactor job_v3 handlebar helper#1936sbliven wants to merge 1 commit intoSciCatProject:masterfrom
job_v3 handlebar helper#1936sbliven wants to merge 1 commit intoSciCatProject:masterfrom
Conversation
Refactors this to reuse the mapJobClassV4toV3 function from the job controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
job_v3handlebars helper to reuse themapJobClassV4toV3function from the job controller. No behavior should change.Motivation
Eliminates an inconsistency and reduces code duplication
Fixes
Changes:
Tests included
Documentation
official documentation info