refactor: improve readability and maintainability of dataset handling#2217
Draft
TheMeinerLP wants to merge 2 commits intoSciCatProject:masterfrom
Draft
refactor: improve readability and maintainability of dataset handling#2217TheMeinerLP wants to merge 2 commits intoSciCatProject:masterfrom
TheMeinerLP wants to merge 2 commits intoSciCatProject:masterfrom
Conversation
Member
|
This refactor looks great. Is it still a work in progress or ready to be reviewd? |
Author
|
I wanted to test this locally, but I'm happy to share it and resolve the merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This small refactor helps maintainers and architects to improve maintainability and readability of the codebase.
Motivation
After I read the code, I found that some parts could be improved for better clarity and structure. This refactor aims to enhance the overall quality of the code.
This helps also to fix bugs faster and have a better software architecture and software design.
In order to enhance the quality of the code, it is recommended that the native features of NestJS and TypeScript be utilised. This approach is to be preferred over the implementation of a substantial if-else function within the code base.
My main idea was to use the layered architecture pattern to separate the concerns of different parts of the application. This helps to improve the maintainability and readability of the code.
Fixes
Changes:
Tests included
Documentation
official documentation info